Repository navigation
Fix Fact Checker model resolution in plan validation - #2045
Merged
Merged
Conversation
Avoid deterministic plan validation failures when the inherited model lacks AI credits pricing. Add regression coverage for the configured model. Refs octodemo/eshop-bradyg-dev#4 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🟡 Impact Analysis — PR #2045Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (2 files, +6 −1)
| File | +/− |
|---|---|
test/gh-aw-plan-lifecycle.test.ts |
+5 −0 |
workflows/squad.md |
+1 −1 |
Total: +6 −1
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review tier: Lite
Findings: None
What changed in this PR
Fixes Fact Checker model resolution during plan validation by replacing the unsupported inherited value with automatic resolution.
Changes:
- Uses
automodel resolution. - Adds regression coverage preventing
inheritedfrom returning.
| File | Summary |
|---|---|
workflows/squad.md |
Updates Fact Checker model resolution. |
test/gh-aw-plan-lifecycle.test.ts |
Verifies the model configuration contract. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan validation currently fails before adversarial review can run because the Fact Checker sub-agent uses the literal
inheritedmodel, which may not have AI credits pricing configured. This was reproduced in octodemo/eshop-bradyg-dev#4.This change uses automatic model resolution for the Fact Checker while preserving the existing fail-closed behavior for unavailable or empty adversarial evidence. It also adds a regression assertion preventing the workflow from returning to the unsupported literal
inheritedmodel.Validation
gh aw compile: passednpm run build: passedgit diff --check: passed